Thankyou Barry.
It seems that my nodeeditor, for this pc especially, is not up to date, with some "obsolete"/ defective nodes.

- Brian

Hi Barry
>> can you make a node of your script please

I was working on a new version of fillet node months ago, with ability to pick corner points directly from the scene, I guess I can add my new findings to it.
It's still buggy and I'm not sure when it'll be ready.

I'm not that skilled too. :)

Hi MO_TE

Thank you for your hard work. You seem very skilled with the Javascript & Nodes.
I like the way that you break up Max's paragraphs of code into individual code lines. This tends to make them more comprehensible IMHO.
Is this "parsing" done by some editing software?
Notepad++ does not break down these code "paragraphs".

- Brian

Thanks Mo,
much appreciated.
Would be good to add fillet and chamfer to the curves section if possible.
Cheers
Barry

Hi Brian
>> You seem very skilled

Thanks, I wish I was. ;)

I use notepad++ with language set to JavaScript.
Maybe this helps you to format/beautify your codes:
https://beautifier.io/

Thank you MO_TE for the JS-beautify link.

"FilletCurve" and "ChamferCurve" nodes
Fillet/chamfer multiple curves at once.
You can choose a specific corner point to fillet or chamfer or set a pattern of 01 to fillet/chamfer curves.


How to use it?
Start nodeeditor and connect your curves to the node.
Click on the "FilletCurve" node to open the information panel.
In the "Select" dropdown menu choose the "sharp points" option.
This way you can see and choose the corner points in the scene.
When you finished picking corner points, choose the "Done" option from "Select" dropdown menu.


Also see the attached "FilletCurve_Showcase.nod" for an example.
Address:
Construct/FilletCurve
Construct/ChamferCurve

Hi Mo,
Excellent will give them a try.
Many thanks
Barry

Excellent!

Hi Mo,
quick update.
When filleting a selected object and applying the original object remains and cannot be deselected as normal (mouse click).
Perhaps keeping original is not needed.
Cheers
Barry

Hi Barry
Thanks for the bug report.
I've fixed the lock selection bug. Try updated version.

Hi Mo,
works fine many thanks.
Barry

In fact we must make our own schema from your example ?
(killing some nodes and save it ) that works fine...
Or there is an original somewhere ?
Or I miss something ?
(here in French for some nodes because i have French enable! :)

Hi PILOU
>> In fact we must make our own schema from your example ?

I modified my main.js to have more colors. But, there should be no difference in terms of working.

>> Or there is an original somewhere ?

Actually, I was working on implementing some new features of this "litegragh" fork into the old nodeeditor. But, I haven't released it yet.
https://github.com/atlasan/litegraph.js

It works nice, But, I have some problems with html and css parts.
I was hoping to find someone interested/skilled to help me finish it! :)

THx for the infos! And alas i can't help you on these difficult domains! :( (for me)

MO,
RE: "FilletCurve" and "ChamferCurve" nodes

This is some impressive work. Indeed the facility for selecting vertices is such a profound contribution, that I really feel it is deserving of its own node.



As well as isolating vertices for fillet/chamfer operations, it could, for example add a trim point on a curve; and in the instance where there were coincidental end point, perform selective joining of curves; etc etc.

Also vertices could be output as points for the locating of other objects/geometry/vectors; or be the targets for operations (eg extrude to point).

Generally I am resistant to the tendency towards node library bloat, but in this case I believe that it would beneficial to take this facility for vertex selection out of your new nodes and universalise it into a dedicated node.

Either way; Brilliant work.
Keep it up.

James
https://www.instagram.com/nodeology/


PS Another thought: Could node have an "index" number array output as an alternative option?

Hi James
Thanks for your ideas. I hadn't thought about using the corner points like this.
Although, I should think more about adding a break to curve or merging curve segments.

I was thinking about adding a new node for selecting sub-objects like edges and faces to use them in filletEdges, blend, offset, inset, extrude, n-sided, network and shell nodes.
Maybe I can add an extra "point" option to it.

One thing I'm not sure about is if is it better to write a "select sub-objects" node and rewrite other nodes above to work with it,
Or, add selection function like "filletCurves" to all of them. (I guess the first one is faster and easier!)

Thanks for your reply, MO

I like the way you're thinking!

If there was an "index" output from "select sub-objects" node, then the nodes: Construct/FilletEdges & Construct/ChamferEdges would not need to be re-written. As for Construct/Extrude etc, would they not perform analogous to Moi menu tool equivalents and accept faces as inputs?



Certainly, the ability to manipulate sub-objects rather than separate breps to discreet surfaces, curves and points and, where necessary, then rejoining; will afford greater control of resultant geometry.

James
https://www.instagram.com/nodeology/

I think adding an index output for selected sub objects is a good idea, but, using this index output in other nodes brings a new challenge:
Some commands like fillet, chamfer, offset, blend and extrude behave differently with curves, edges and faces.
For example, I'm not sure how to distinguish an index for a node like "offset". should it behave like an edge/curve index or a face index or an objectlist index ?

I made a "Select_SubObjects" node. It has two outputs (for now). One output for edge/face sub objects, another one for extracting selected sub objects as separate objects.
It works nice with extrude and shell nodes without needing to change anything.
Also, adding a corner point output for fillet/chamfer is another good idea. Thanks :)

MO,

I am looking forward to getting my hands on "Select_SubObjects" node.


The variance of operation on sub-0bject types has already been dealt with for filleting and chamfering.
Maybe a similar approach is required for offsetting.



As you alluded to extruding behaves consistently regardless of input types,
Blending only works with edges and curves, so it may also require separate nodes or ideally separate modes within "Blend" node.

Does existing Construct2/Blend node work with your "Select_SubObjects" node?

James
https://www.instagram.com/nodeology/