Hi Max

Excepting the bug "Invalid function argument 1 line0" I get when running pentakisDodeca&TruncIcosa.nod (see http://moi3d.com/forum/index.php?webtag=MOI&msg=7777.757), all other .nod files run perfectly.

However generally I have the following error intermittently when trackpad navigating & resizing within NE interface. It appears to be triggered by 2 finger gestures (pan & zoom)

---

TypeError: undefined is not a constructor (evaluating 'this.getCanvasWindow()')

moi://ui/nodeeditor/core/main.js line 4509

4505: case "touchend": type="mouseup"; break;
4506: default: return;
4507: }
4508:
4509: >> var window = this.getCanvasWindow();
4510: var document = window.document;
4511:
4512: var simulatedEvent = document.createEvent("MouseEvent");
4513: simulatedEvent.initMouseEvent(type, true, true, window, 1, first.screenX, first.screenY, first.clientX, first.clientY, false, false, false, false, 0/*left*/, null);

---

Thank you for your great work
James

Hi Max

I spoke too soon. Attached is an example that runs v3 but not v4.

James

Hi Max,

I feel like a real coder now, having changed a "," into a ";". :D

Thank you too!

Yes you just understand that the world's stability depends only on "'" , ",", ":" and sometime ";" without speak about "{" or "}" :)

And alas surely miss some important ones! For exaple the "." :D

@ Frenchy: :D

Hello Max.

I've assembled another (I hope) useful model to test your SubDiv scripts and its results.

You can find it at :

http://moi3d.com/forum/index.php?webtag=MOI&msg=8667.47

Ciao ;)

Marco (mkdm)

James
>>I updated my post with new error message
Lets wait the next MoI v4 beta

>>However generally I have the following error intermittently when trackpad navigating & resizing within NE interface.
Sorry, I don't use trackpad, so I can't find a solution of this problem right now.
But few weeks ago I made some changes in functions which affects on getCanvasWindow. I will release a new NE version soon.

Metin
>> I feel like a real coder now, having changed a "," into a ";". :D
Thank you :) It was just a typo.

Marco
Thank you
But I have no plans to continue development of the Subd script this year.

Hi Max.

@You : “Lets wait the next MoI v4 beta”

Wise decision!

@You : “But I have no plans to continue development of the Subd script this year.”

No problem Max. I can understand.
You already did a wanderul job (and also for free!)

Ciao.

Hi Max

Thanks for the update v.0.98.

FYI

>> I made some changes in functions which affects on getCanvasWindow.<<

Despite the changes, the error perists with2 finger trackpad gestures.

---

TypeError: undefined is not a constructor (evaluating 'this.getCanvasWindow()')

moi://ui/nodeeditor/core/main.js line 4508

4504: case "touchend": type="mouseup"; break;
4505: default: return;
4506: }
4507:
4508: >> var window = this.getCanvasWindow();
4509: var document = window.document;
4510:
4511: var simulatedEvent = document.createEvent("MouseEvent");
4512: simulatedEvent.initMouseEvent(type, true, true, window, 1, first.screenX, first.screenY, first.clientX, first.clientY, false, false, false, false, 0/*left*/, null);

---

I understand that without a MacBook Pro or trackpad periphery device you can't test & find solution, but am reporting it so you are aware.

Thanks
James

Hi James,
thank you for this bugreport

I made some changes to main.js
http://moi.maxsm.net/nodeeditor/main.js
Try it

Hi Max

Thank you for main.js
It fixed the error message, however there is still some anomalous behaviour with zoom (2 fingers up & down)
Sometime it works, while other time it draws a selection box. This is also true for panning: works intermittently.

Also control clicking on a node does not create a copy of the node.
This is a particularly useful feature, but I think it may have been absent prior to new main.js

Thanks for looking at this. At least now it is possible now to work with NE in v4

Regards
James

Hi Max,

i found a bug in nodeeditor...

if you have a slider or knob you can change values with the mousewheel - but if you use a MagicMouse2 or a trackpad it causes NaN if you scroll sideways...

if i go to interface.js and delete all the:

############
WidgetKnob.prototype.onMouseWheel = function(e)
{
var v = this.internal.position;
var delta = e.wheelDeltaY/Math.abs(e.wheelDeltaY)/100;
var time = LiteGraph.getTime();
if ( time - this.local.wheelTime < 50 ) { delta *=5 }
else if ( time - this.local.wheelTime < 100 ) { delta *=2; }
this.local.wheelTime = time;
v += delta;
if (v> 1.0) { v = 1.0 } else if (v < 0.0) { v = 0.0 }

this.internal.position = v;
this.properties.value = this.properties.min + (this.properties.max - this.properties.min) * this.internal.position;
this.properties.value = this.properties.value.toFixed(this.properties.digits);
this.updateThisNodeGraph();
this.graph.setisChangedFlag(this.id);
}
############

No more Mousewheel ;-(
but no more NaNs :-)

THX for nodeeditor!!

Hi Ralf,

thank you for bugreport.
Try to replace this line

var delta = e.wheelDeltaY/Math.abs(e.wheelDeltaY)/100;

with this one

var delta = e.wheelDeltaY || e.wheelDeltaX; delta = delta/Math.abs(delta)/100;

YES! Thats it!

The mousewheel doesnt make any NaNs anymore :)

Thank you

I fixed Knob and Slider nodes.
You can download updated interface.js here: http://moi.maxsm.net/nodeeditor/

Tireless repairing! ;)

PS new French lang.js (3 dec 2017)
http://moiscript.weebly.com/uploads/3/9/3/8/3938813/lang.js

edit: same address but modified!
http://moiscript.weebly.com/uploads/3/9/3/8/3938813/lang.js

Does all that (+ nodeditor) works also for the V3 or it's only for the beta V 4 ?

Hi Max,
Thanks for node editor update.
where we put interface.js and index.htm file ?

Frenchy Pilou
>>Does all that (+ nodeditor) works also for the V3 or it's only for the beta V 4 ?
Yes. The current version of nodeeditor are fully compatible with all v3/v4 win/mac MoI versions.

Finema
>>where we put interface.js and index.htm file ?
nodeeditor/nodes/interface.js
nodeeditor/index.htm

Hi Finema,

just there:

Thanks Max & Ralf :)