Full Version: Node Wish List

Show messages:  1-12  …  313-332  333-352  353-372  373-392  393-412  413-425

Hi Mo,

Re: Am I missing something?

Is there a specific problem with the script, aside from the needed extensions that you list, or are you asking about the general approach?

One general potential problem is that the input currently accepts a list of curves, but it seems like the cornersList approach will only work for a single joined curve.

Also, filleting behaves differently if the input is 2 curves: it tries to mutually extend the curves and connect them with a fillet segment even though the input curves aren't G0.

- Peer

---

Hi All,
Just to add to my previous post.
This issue does not happen if done manually with moi fillet tool.
So perhaps Michael can shed some light on the issue.
Anyway Brian’s crvFillet node woks fine with open / closed and 3D curves.

Brian
is it possible to comment out the select input ?
I tried but didn’t work.
Many thanks
Barry

---

Hi Peer
>> One general potential problem is that the input currently accepts a list of curves, but it seems like the cornersList approach will only work for a single joined curve.

I wanted to keep it simple, this code is supposed to work just on a single curve.
I know I can fillet corner points of a curve, using a list of true/false values.
What I don't understand is why it won't work on for example an open curve with one corner point. (a V shape curve)
It actually needs a list of two (or more?) to work, while the generateVertices() method returns one vertex.

---

Also since v4 there is this function on curve segments:

Added CurveSegment.getIsG1ToAdjacentSegment( 0 /* 0 for start, 1 for end */ );
- returns true if the next segment at the start or end is smooth to the current curve segment.

- Michael

---

So, I found my mistake on fillet factory.
I thought the corners list's length should be equal to length of points generated by "generateVertices()" method.
But, It seems it should be equal to segments count.
That's why fillet node generates that curly effect in Barry's screenshots. It tries to fillet all corner points including the "G1" corner points

I just filtered the real "G0" points out of all corner points (segments start points).

script:
var inputs = moi.geometryDatabase.getSelectedObjects().getStandaloneCurves();
var filletFacc = moi.command.createFactory('fillet');
var filletFacToGetCorners = moi.command.createFactory('fillet');
filletFacToGetCorners.setInput(0, inputs);
filletFacToGetCorners.generateVertices();
var corners = filletFacToGetCorners.getCreatedObjects();
var segments = inputs.item(0).getSubObjects();
var startPoints = [];
for(k=0; k<segments.length; k++)
{
	startPoints.push(segments.item(k).getStartPt());
}
filletFacToGetCorners.cancel();
var cornersList = moi.createList();
for ( var i = 0; i < startPoints.length; ++i ) 
{
	if(isG0Connection(startPoints[i],corners)){cornersList.add( true );}
	else{cornersList.add( false );}
}
filletFacc.setInput(0, inputs);
filletFacc.setInput(1, false);
filletFacc.setInput(2, cornersList);
filletFacc.setInput(3, 1);
filletFacc.setInput(4, 'Circular');
filletFacc.setInput(5, 1);
filletFacc.commit();
moi.log("inputs: "+inputs.length+"\n");
moi.log("Corners: "+corners.length+"\n");
moi.log("cornersList: \n");
for ( var i = 0; i < cornersList.length; ++i ) {moi.log(cornersList.item(i)+"\t")};
moi.log("\n");

function isG0Connection(point, G0Points)
{
	var isSamePoint = false;
	for(j=0; j<G0Points.length; j++)
	{
		if(point.x == G0Points.item(j).pt.x && point.y == G0Points.item(j).pt.y && point.z == G0Points.item(j).pt.z)
		{
			isSamePoint = true;
			break;
		}else{isSamePoint = false;}
	}
	return isSamePoint;
}

---

Hi Mo,
can you make a node of your script please
I have very limited coding and will probably take forever.
Cheers
Barry

---

Link on (various) Fillet node(s), and Chamfer node(s), from 2 and 4 years ago, with good information from Michael:

https://moi3d.com/forum/index.php?webtag=MOI&msg=9666.1

(various Fillet and Chamfer nodes, are located in nodeeditor menus Curves2 and Construct2 menus. Some of them are probably not mature, fully functional nodes, and may need improvements from someone who knows what they are doing. And has understanding (?)) (Like grafting in MO-TE's code ?)

- Brian

---

Hi Brian,
I've just removed them from my nodeditor as Mo added new versions of fillet and chamfer edges into the construct menu.
I think a new thread maybe worth starting to filter out some of duplicate nodes and add new developed nodes that people want to share.
Anyway many thanks for your input.
Cheers
Barry

---

Thankyou Barry.
It seems that my nodeeditor, for this pc especially, is not up to date, with some "obsolete"/ defective nodes.

- Brian

---

Hi Barry
>> can you make a node of your script please

I was working on a new version of fillet node months ago, with ability to pick corner points directly from the scene, I guess I can add my new findings to it.
It's still buggy and I'm not sure when it'll be ready.

I'm not that skilled too. :)

---

Hi MO_TE

Thank you for your hard work. You seem very skilled with the Javascript & Nodes.
I like the way that you break up Max's paragraphs of code into individual code lines. This tends to make them more comprehensible IMHO.
Is this "parsing" done by some editing software?
Notepad++ does not break down these code "paragraphs".

- Brian

---

Thanks Mo,
much appreciated.
Would be good to add fillet and chamfer to the curves section if possible.
Cheers
Barry

---

Hi Brian
>> You seem very skilled

Thanks, I wish I was. ;)

I use notepad++ with language set to JavaScript.
Maybe this helps you to format/beautify your codes:
https://beautifier.io/

---

Thank you MO_TE for the JS-beautify link.

---

"FilletCurve" and "ChamferCurve" nodes
Fillet/chamfer multiple curves at once.
You can choose a specific corner point to fillet or chamfer or set a pattern of 01 to fillet/chamfer curves.


How to use it?
Start nodeeditor and connect your curves to the node.
Click on the "FilletCurve" node to open the information panel.
In the "Select" dropdown menu choose the "sharp points" option.
This way you can see and choose the corner points in the scene.
When you finished picking corner points, choose the "Done" option from "Select" dropdown menu.


Also see the attached "FilletCurve_Showcase.nod" for an example.
Address:
Construct/FilletCurve
Construct/ChamferCurve

Attachments:
ChamferCurve.js
FilletCurve.js
FilletCurve_Showcase.nod

Image Attachments:
FilletCurve_ChamferCurve_Nodes.png  FilletCurve_Vid-ezgif.com-optimize.gif 

---

Hi Mo,
Excellent will give them a try.
Many thanks
Barry

---

Excellent!

---

Hi Mo,
quick update.
When filleting a selected object and applying the original object remains and cannot be deselected as normal (mouse click).
Perhaps keeping original is not needed.
Cheers
Barry

---

Hi Barry
Thanks for the bug report.
I've fixed the lock selection bug. Try updated version.

---

Hi Mo,
works fine many thanks.
Barry

---

Show messages:  1-12  …  313-332  333-352  353-372  373-392  393-412  413-425