Full Version: Node Wish List

Show messages:  1-18  …  299-318  319-338  339-358  359-378  379-398  399-418  419-425

Based on Max's node.

Attachments:
RevSwitch.nod
switchRevers.js

---

I "dis-remembered" that there are 3 types :-(, :-).
Recall seeing type code for 3 types.

- Brian

If the switch were for electronics, there might be a "pull up" resister on each output terminal?

The code that I did was all modifications of Max's code.
Will look at switchReverse later today.

---

Hi WN,
thanks for the node but having issues when directing input from one circuit to another.
Attached a nod file showing the issue.
One circuit adds a fillets to the input square & the second does not.
Using the numbers option seems Ok.
Cheers
Barry

Attachments:
RevSwitch.nod

---

Hi Barry.
In fact, there is no need for this node, since there are the necessary nodes for this.
I assume that you are aware of this. The node that I uploaded here is a small fix for
the 'Switch' node with a small addition from the 'Split' node that is in the 'logic' file.
I fixed the error and updated the file in the same message.

WN.

---

Hi WN,
thank you for the node works fine.
Yes split node does the same (not used it before).
Many thanks
Barry

---

Hi WN,
It was a pleasure to review your RevSwitch file, to see the numerous corrections to the SwSPDT.js file that I did in an attempt to modify Max's Switch node.
Number of inputs and outputs, for each of the 3 datatypes was done.
(Code from Logic > Split node, I see.)
I broke the bezier color somehow.
I see that you modified the bezier, somehow, using the "same" code.
You introduced the dataNull.

Even though the RevSwitch function is already covered in the Logic > Split node, the Bezier indicator curve is nice to see.

- Brian

---

Hi,
not sure if there is a answer for this
Shown is a photo showing a square that as one corner already filleted.
When object is selected and crvfilllet node used to fillet the remaining corners
it produces the result on the right or fails.
Any ideas ?
Cheers
Barry

Image Attachments:
Screenshot (776).png 

---

It looks like the node is trying to fillet points 4 and 5.

Is there a way to exclude the end points of the pre-existing fillet, from the new fillet?

- Brian

Can the initial object be posted?
Would a join help?

Is there some way to identify all of the characteristics of the points?

---

Hi Brian,
the node needs away of knowing if the point is G0.
If the curve is rebuilt it works fine but you end up with a lot more control points.
Barry

---

Moi4 introduced a bunch of methods, tangents and derivatives...etc

---

Hi Brian,

Here's a function for checking if a pair of curves is G1.

- Peer

// returns true if curve1 is tangent to curve2
function getCurvePairIsG1(curve1, curve2) {

    var curve1startPt = curve1.getStartPt();
    var curve1endPt = curve1.getEndPt();
    var curve1startTan = curve1.evaluateTangent(curve1.domainMin);
    var curve1endTan = curve1.evaluateTangent(curve1.domainMax);

    var curve2startPt = curve2.getStartPt();
    var curve2endPt = curve2.getEndPt();
    var curve2startTan = curve2.evaluateTangent(curve2.domainMin);
    var curve2endTan = curve2.evaluateTangent(curve2.domainMax);

    // flip one of the tangent vectors in the pair being compared for end-end and start-start cases
    var curve1startTanNeg = moi.vectorMath.createPoint(curve1startTan.x, curve1startTan.y, curve1startTan.z);
    curve1startTanNeg.scale(-1.0);

    var curve1endTanNeg = moi.vectorMath.createPoint(curve1endTan.x, curve1endTan.y, curve1endTan.z);
    curve1endTanNeg.scale(-1.0);

    var tol = moi.geometryDatabase.tolerance;

    // curve1 start curve2 end
    if (
        moi.vectorMath.distance(curve1startPt, curve2endPt) < tol &&
        moi.vectorMath.distance(curve1startTan, curve2endTan) < tol
    ) {
        return true;
    }

    // curve1 end curve2 start
    else if (
        moi.vectorMath.distance(curve1endPt, curve2startPt) < tol &&
        moi.vectorMath.distance(curve1endTan, curve2startTan) < tol
    ) {
        return true;
    }

    // curve1 start curve2 start
    else if (
        moi.vectorMath.distance(curve1startPt, curve2startPt) < tol &&
        moi.vectorMath.distance(curve1startTanNeg, curve2startTan) < tol
    ) {
        return true;
    }

    // curve2 end curve2 end
    else if (
        moi.vectorMath.distance(curve1endPt, curve2endPt) < tol &&
        moi.vectorMath.distance(curve1endTanNeg, curve2endTan) < tol
    ) {
        return true;
    }

    else {
        return false;
    }
}

---

Hi Brian,

Or for a planar joined curve you can use a G1 checker that's built into fillet factories. Search "GetCorners" in the API for an example of how to do that.

- Peer

---

I tried to fillet a selected curve with code below.
It makes a list of "true" values for all corner points of the curve to fillet all of them.
Let's say I have a polyline consists of two segments and one corner point.
Logically, the corners List should be like this : {true}
This approach works on closed curves like a rectangle, but, fails on open curves. I need to add an extra "true" value to the list for open curves to work.
Also it fails on open and closed curves with an existing fillet or non "G0" continuity.
Like the one Barry showed in (9581.365)

Am I missing something?

script:
var inputs = moi.geometryDatabase.getSelectedObjects().getStandaloneCurves();
var filletFacc = moi.command.createFactory('fillet');
var filletFacToGetCorners = moi.command.createFactory('fillet');
filletFacToGetCorners.setInput(0, inputs);
filletFacToGetCorners.generateVertices();
var corners = filletFacToGetCorners.getCreatedObjects();
filletFacToGetCorners.cancel();
var cornersList = moi.createList();
if(inputs.item(0).isClosed)
{
for ( var i = 0; i < corners.length; ++i ) {cornersList.add( true );};
}else
{
for ( var i = -1; i < corners.length; ++i ) {cornersList.add( true );};
}
filletFacc.setInput(0, inputs);
filletFacc.setInput(1, false);
filletFacc.setInput(2, cornersList);
filletFacc.setInput(3, 1);
filletFacc.setInput(4, 'Circular');
filletFacc.setInput(5, 1);
filletFacc.commit();
moi.log("inputs: "+inputs.length+"\n");
moi.log("Corners: "+corners.length+"\n");
moi.log("cornersList: \n");
for ( var i = 0; i < cornersList.length; ++i ) {moi.log(cornersList.item(i)+"\t")};
moi.log("\n");

---

Hi Peer,

Your code and reference look to be superb solutions.

At this time, I have too many projects, and too little time and energy, to work on this.

- Brian
( Not to mention limited ability :-)

---

Hi Mo,

Re: Am I missing something?

Is there a specific problem with the script, aside from the needed extensions that you list, or are you asking about the general approach?

One general potential problem is that the input currently accepts a list of curves, but it seems like the cornersList approach will only work for a single joined curve.

Also, filleting behaves differently if the input is 2 curves: it tries to mutually extend the curves and connect them with a fillet segment even though the input curves aren't G0.

- Peer

---

Hi All,
Just to add to my previous post.
This issue does not happen if done manually with moi fillet tool.
So perhaps Michael can shed some light on the issue.
Anyway Brian’s crvFillet node woks fine with open / closed and 3D curves.

Brian
is it possible to comment out the select input ?
I tried but didn’t work.
Many thanks
Barry

---

Hi Peer
>> One general potential problem is that the input currently accepts a list of curves, but it seems like the cornersList approach will only work for a single joined curve.

I wanted to keep it simple, this code is supposed to work just on a single curve.
I know I can fillet corner points of a curve, using a list of true/false values.
What I don't understand is why it won't work on for example an open curve with one corner point. (a V shape curve)
It actually needs a list of two (or more?) to work, while the generateVertices() method returns one vertex.

---

Also since v4 there is this function on curve segments:

Added CurveSegment.getIsG1ToAdjacentSegment( 0 /* 0 for start, 1 for end */ );
- returns true if the next segment at the start or end is smooth to the current curve segment.

- Michael

---

So, I found my mistake on fillet factory.
I thought the corners list's length should be equal to length of points generated by "generateVertices()" method.
But, It seems it should be equal to segments count.
That's why fillet node generates that curly effect in Barry's screenshots. It tries to fillet all corner points including the "G1" corner points

I just filtered the real "G0" points out of all corner points (segments start points).

script:
var inputs = moi.geometryDatabase.getSelectedObjects().getStandaloneCurves();
var filletFacc = moi.command.createFactory('fillet');
var filletFacToGetCorners = moi.command.createFactory('fillet');
filletFacToGetCorners.setInput(0, inputs);
filletFacToGetCorners.generateVertices();
var corners = filletFacToGetCorners.getCreatedObjects();
var segments = inputs.item(0).getSubObjects();
var startPoints = [];
for(k=0; k<segments.length; k++)
{
	startPoints.push(segments.item(k).getStartPt());
}
filletFacToGetCorners.cancel();
var cornersList = moi.createList();
for ( var i = 0; i < startPoints.length; ++i ) 
{
	if(isG0Connection(startPoints[i],corners)){cornersList.add( true );}
	else{cornersList.add( false );}
}
filletFacc.setInput(0, inputs);
filletFacc.setInput(1, false);
filletFacc.setInput(2, cornersList);
filletFacc.setInput(3, 1);
filletFacc.setInput(4, 'Circular');
filletFacc.setInput(5, 1);
filletFacc.commit();
moi.log("inputs: "+inputs.length+"\n");
moi.log("Corners: "+corners.length+"\n");
moi.log("cornersList: \n");
for ( var i = 0; i < cornersList.length; ++i ) {moi.log(cornersList.item(i)+"\t")};
moi.log("\n");

function isG0Connection(point, G0Points)
{
	var isSamePoint = false;
	for(j=0; j<G0Points.length; j++)
	{
		if(point.x == G0Points.item(j).pt.x && point.y == G0Points.item(j).pt.y && point.z == G0Points.item(j).pt.z)
		{
			isSamePoint = true;
			break;
		}else{isSamePoint = false;}
	}
	return isSamePoint;
}

---

Hi Mo,
can you make a node of your script please
I have very limited coding and will probably take forever.
Cheers
Barry

---

Show messages:  1-18  …  299-318  319-338  339-358  359-378  379-398  399-418  419-425